Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk: supports triggering on-demand balancer #22855

Merged
merged 1 commit into from
Aug 22, 2024
Merged

rpk: supports triggering on-demand balancer #22855

merged 1 commit into from
Aug 22, 2024

Conversation

daisukebe
Copy link
Contributor

@daisukebe daisukebe commented Aug 13, 2024 •
edited
Loading

Although the continuous balancer has been becoming smart, there's still needs where we need to invoke the on-demand balancer to balance partitions across brokers. This commit adds a new rpk cluster partitions balance command that wraps the POST /v1/partitions/rebalance endpoint.

Internal discussion: https://redpandadata.slack.com/archives/C04LYNJQUGN/p1722580784813209

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

Features

  • rpk: supports triggering on-demand partition balancer

@daisukebe
Copy link
Contributor Author

daisukebe commented Aug 13, 2024 •
edited
Loading

I should have updated rpadmin first. Tagged v0.1.4 https://github.com/redpanda-data/common-go/tree/rpadmin/v0.1.4/rpadmin, but it's not in the main branch. Created redpanda-data/common-go#12 there.

@daisukebe daisukebe mentioned this pull request Aug 13, 2024
Merged
@r-vasquez
Copy link
Contributor

@daisukebe Can you please delete and recreate the tag from main once redpanda-data/common-go#12 is merged?

@daisukebe daisukebe force-pushed the rpk-ondemand-balancer branch 2 times, most recently from 414cf84 to 72ee8ca Compare August 14, 2024 15:34
@daisukebe
Copy link
Contributor Author

Force pushed: 72ee8ca

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Aug 14, 2024 •
edited
Loading

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/52920#019151c9-88c8-4d35-923b-dc4aed2aa181

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/53021#01915927-bca7-48c0-94ec-96f34a4503a6

r-vasquez
r-vasquez previously approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@r-vasquez r-vasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thanks!

@daisukebe daisukebe force-pushed the rpk-ondemand-balancer branch from 120a32a to 8164de9 Compare August 16, 2024 01:50
@daisukebe
Copy link
Contributor Author

Force pushed: 8164de9

  • Applied Joyce's suggestion on the help text
  • Fixed the typo
  • Removed the formatter

Deflaimun
Deflaimun previously approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@Deflaimun Deflaimun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from docs

@daisukebe daisukebe force-pushed the rpk-ondemand-balancer branch from 8164de9 to 878f815 Compare August 21, 2024 03:15
@daisukebe
Copy link
Contributor Author

Force pushed again (sorry) to align with wording; balancer -> balancing.

@daisukebe daisukebe force-pushed the rpk-ondemand-balancer branch from 878f815 to 6203116 Compare August 21, 2024 05:56
@daisukebe daisukebe requested a review from r-vasquez August 21, 2024 05:57
r-vasquez
r-vasquez approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@r-vasquez r-vasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@daisukebe daisukebe merged commit 38aace7 into redpanda-data:dev Aug 22, 2024
22 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v24.2.x

@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v24.2.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-22855-v24.2.x-250 remotes/upstream/v24.2.x
git cherry-pick -x 62031165e3c6867939e182a4066bf6831088248a

Workflow run logs.

@vbotbuildovich vbotbuildovich mentioned this pull request Aug 22, 2024
Closed
@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v24.1.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-22855-v24.1.x-736 remotes/upstream/v24.1.x
git cherry-pick -x 62031165e3c6867939e182a4066bf6831088248a

Workflow run logs.

@vbotbuildovich vbotbuildovich mentioned this pull request Aug 22, 2024
Open
@daisukebe daisukebe mentioned this pull request Sep 6, 2024
Merged
7 tasks
@daisukebe daisukebe mentioned this pull request Sep 20, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ztlpn ztlpn ztlpn left review comments

@twmb twmb twmb left review comments

@r-vasquez r-vasquez r-vasquez approved these changes

@Deflaimun Deflaimun Deflaimun left review comments

@gene-redpanda gene-redpanda Awaiting requested review from gene-redpanda gene-redpanda is a code owner

@Feediver1 Feediver1 Awaiting requested review from Feediver1

Assignees
No one assigned
Labels
area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@daisukebe @r-vasquez @vbotbuildovich @twmb @ztlpn @Deflaimun @Feediver1